linux-kernel - Re: [PATCH] platform/x86/tuxedo: Prevent invalid Kconfig state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <715d3f5f-e138-41c2-a7eb-359b2fe6e6c0@tuxedocomputers.com>
Date: Mon, 12 May 2025 13:16:53 +0200
From: Werner Sembach <wse@...edocomputers.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: rdunlap@...radead.org, sfr@...b.auug.org.au, linux-next@...r.kernel.org,
 W_Armin@....de, Hans de Goede <hdegoede@...hat.com>,
 platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86/tuxedo: Prevent invalid Kconfig state


Am 12.05.25 um 12:57 schrieb Ilpo Järvinen:
> On Mon, 12 May 2025, Werner Sembach wrote:
>
>> It was possible to create a uncompileable config, because of missing
>> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
>>
>> For reference:
>> https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/
> Please add a Reported-by tag and you can put that URL into Link: tag.
Ok
>
>> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
>> ---
>>   drivers/platform/x86/tuxedo/nbxx/Kconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/platform/x86/tuxedo/nbxx/Kconfig b/drivers/platform/x86/tuxedo/nbxx/Kconfig
>> index 1701374a039d2..9eecbe8127df7 100644
>> --- a/drivers/platform/x86/tuxedo/nbxx/Kconfig
>> +++ b/drivers/platform/x86/tuxedo/nbxx/Kconfig
> Eh, what's this path? There's only nb04/.
Sorry brainfail was on the wrong branch, just looks almost the same
>
>> @@ -7,6 +7,8 @@
>>   
>>   config TUXEDO_NBXX_ACPI_TUXI
>>   	tristate "TUXEDO NBxx ACPI TUXI Platform Driver"
>> +	depends on ACPI_WMI
>> +	depends on HID
>>   	help
>>   	  This driver implements the ACPI TUXI device found on some TUXEDO
>>   	  notebooks. This enables the control of built-in fans via HWMON.
>>