linux-kernel - Re: [PATCH rdma-next v4 4/4] net: mana: Add support for auxiliary device servicing events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250512113248.GE22843@unreal>
Date: Mon, 12 May 2025 14:32:48 +0300
From: Leon Romanovsky <leon@...nel.org>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>
Cc: Konstantin Taranov <kotaranov@...ux.microsoft.com>,
	kotaranov@...rosoft.com, pabeni@...hat.com, haiyangz@...rosoft.com,
	kys@...rosoft.com, edumazet@...gle.com, kuba@...nel.org,
	davem@...emloft.net, decui@...rosoft.com, wei.liu@...nel.org,
	longli@...rosoft.com, jgg@...pe.ca, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH rdma-next v4 4/4] net: mana: Add support for auxiliary
 device servicing events

On Mon, May 12, 2025 at 10:59:43AM +0530, ALOK TIWARI wrote:
> 
> 
> On 07-05-2025 21:29, Konstantin Taranov wrote:
> > From: Shiraz Saleem <shirazsaleem@...rosoft.com>
> > 
> > Handle soc servcing events which require the rdma auxiliary device resources to
> 
> typo servcing ->servicing

<...>

> > +		val = service_data.value;
> 
> what is use of val?
> 

<...>

> > +static void mana_handle_rdma_servicing(struct work_struct *work)
> 
> this name does not sound clearer and more aligned with typical naming
> conventions.
> Since it is an RDMA service event handler, it could be named to
> mana_rdma_service_handle. What are your thoughts on this?"

I fixed all these comments locally when applied the series.
Thank you for the review.