linux-kernel - Re: [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12c262c0-07a8-4266-899f-45cd42dc7cd0@amlogic.com>
Date: Mon, 12 May 2025 10:26:37 +0800
From: Xianwei Zhao <xianwei.zhao@...ogic.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
 Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 linux-amlogic@...ts.infradead.org, linux-gpio@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 llvm@...ts.linux.dev
Subject: Re: [PATCH] pinctrl: meson: Drop unused aml_pctl_find_group_by_name()

Reviewed-by: Xianwei Zhao <xianwei.zhao@...ogic.com>

On 2025/5/9 23:01, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> aml_pctl_find_group_by_name() is not used anywhere, as reported by W=1
> clang build:
> 
>    pinctrl-amlogic-a4.c:600:2: error: unused function 'aml_pctl_find_group_by_name' [-Werror,-Wunused-function]
> 
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 14 --------------
>   1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> index a76f266b4b94..385cc619df13 100644
> --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> @@ -596,20 +596,6 @@ static int aml_get_group_pins(struct pinctrl_dev *pctldev,
>          return 0;
>   }
> 
> -static inline const struct aml_pctl_group *
> -       aml_pctl_find_group_by_name(const struct aml_pinctrl *info,
> -                                   const char *name)
> -{
> -       int i;
> -
> -       for (i = 0; i < info->ngroups; i++) {
> -               if (!strcmp(info->groups[i].name, name))
> -                       return &info->groups[i];
> -       }
> -
> -       return NULL;
> -}
> -
>   static void aml_pin_dbg_show(struct pinctrl_dev *pcdev, struct seq_file *s,
>                               unsigned int offset)
>   {
> --
> 2.45.2
>