linux-kernel - Re: [PATCH] net: bcmgenet: tidy up stats, expose more stats in ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <244e2b38-b1bf-4632-afa1-acc018bb20dc@lunn.ch>
Date: Mon, 12 May 2025 14:24:23 +0200
From: Andrew Lunn <andrew@...n.ch>
To: zakkemble@...il.com
Cc: Doug Berger <opendmb@...il.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bcmgenet: tidy up stats, expose more stats in
 ethtool

On Sun, May 11, 2025 at 10:40:36PM +0100, zakkemble@...il.com wrote:
> From: Zak Kemble <zakkemble@...il.com>
> 
> This patch exposes more statistics counters in ethtool and tidies up the
> counters so that they are all per-queue. The netdev counters are now only
> updated synchronously in bcmgenet_get_stats instead of a mix of sync/async
> throughout the driver. Hardware discarded packets are now counted in their
> own missed stat instead of being lumped in with general errors.

Hi Zak

That sounds like a list. When i see a list in a commit message, i
think the patch needs splitting up into smaller pieces.


    Andrew

---
pw-bot: cr