linux-kernel - Re: [PATCH v3 0/4] Describe the cameras in the PinePhone Pro dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174705404383.2941320.1978376350297662131.robh@kernel.org>
Date: Mon, 12 May 2025 07:49:33 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Olivier Benjamin <olivier.benjamin@...tlin.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, 
 linux-media@...r.kernel.org, Nicholas Roth <nicholas@...hemail.net>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, imx@...ts.linux.dev, 
 linux-rockchip@...ts.infradead.org, Shawn Guo <shawnguo@...nel.org>, 
 Pengutronix Kernel Team <kernel@...gutronix.de>, 
 Ondrej Jirman <megi@....cz>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
 Krzysztof Kozlowski <krzk@...nel.org>, Heiko Stuebner <heiko@...ech.de>, 
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 Sascha Hauer <s.hauer@...gutronix.de>, 
 Jacopo Mondi <jacopo.mondi@...asonboard.com>, 
 Dragan Simic <dsimic@...jaro.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v3 0/4] Describe the cameras in the PinePhone Pro dts


On Fri, 09 May 2025 23:51:36 +0200, Olivier Benjamin wrote:
> This series adds support for the Pine64 PinePhone Pro's rear and front
> cameras in Device Tree.
> This is based on some of Ondrej Jirman's patches hosted in his tree at
> https://codeberg.org/megi/linux, but I have also fully reviewed and
> re-written the code from the RK3399 datasheet, the PinePhone Pro
> schematic, and the IMX258-0AQH5 software reference manual.
> 
> I have tested these changes on my PinePhone Pro and am able to take
> photos from both cameras using libcamera's cam.
> 
> Signed-off-by: Olivier Benjamin <olivier.benjamin@...tlin.com>
> ---
> Changes in v3:
> - Fixed new DTB warnings reported by Rob Herring's bot
> - Link to v2: https://lore.kernel.org/r/20250302-camera-v2-0-312b44b4a89c@bootlin.com
> 
> Changes in v2:
> - Rebase on mainline
> - Change patch subject to arm64: dts: rockchip
> - Rename new regulators to fit preferred form for fixed regulators
> - Link to v1: https://lore.kernel.org/r/20250228-camera-v1-0-c51869f94e97@bootlin.com
> 
> ---
> Olivier Benjamin (4):
>       dt-bindings: media: ov8858: inherit video-interface-devices properties
>       dt-bindings: media: imx258: inherit video-interface-devices properties
>       arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro
>       arm64: dts: rockchip: describe the OV8858 user camera on PinePhone Pro
> 
>  .../devicetree/bindings/media/i2c/ovti,ov8858.yaml |   4 +-
>  .../devicetree/bindings/media/i2c/sony,imx258.yaml |   4 +-
>  .../boot/dts/rockchip/rk3399-pinephone-pro.dts     | 139 +++++++++++++++++++++
>  3 files changed, 145 insertions(+), 2 deletions(-)
> ---
> --
> Olivier Benjamin <olivier.benjamin@...tlin.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.15-rc1-102-g2332d042e9b2 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250509-camera-v3-0-dab2772d229a@...tlin.com:

arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dtb: camera@1a (sony,imx258): Unevaluated properties are not allowed ('clock-names' was unexpected)
	from schema $id: http://devicetree.org/schemas/media/i2c/sony,imx258.yaml#