linux-kernel - Re: [PATCH] MAINTAINERS: add mm GUP section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9AF9CF7D-D4A3-4D97-9B7D-F259E33E982C@nvidia.com>
Date: Mon, 12 May 2025 08:54:53 -0400
From: Zi Yan <ziy@...dia.com>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 David Hildenbrand <david@...hat.com>, Uladzislau Rezki <urezki@...il.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Jason Gunthorpe <jgg@...dia.com>,
 John Hubbard <jhubbard@...dia.com>, Peter Xu <peterx@...hat.com>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS: add mm GUP section

On 12 May 2025, at 3:38, Vlastimil Babka wrote:

> On 5/8/25 14:23, Lorenzo Stoakes wrote:
>>>
>>> M for "PAGE ALLOCATOR", hmmm ..., I was hoping that Vlastimil might have
>>> capacity for that? :)
>>
>> Vlastimil? ;)
>>
>> I'd certainly support this.
>
> OK, can do, thanks.
>
>>>
>>>
>>>
>>> Not 100% sure what to do with
>>>
>>> * include/linux/page_isolation.h
>>> * mm/page_isolation.c
>>>
>>> (I hate the word "page isolation")
>>>
>>> They are mostly about page migration (either for alloc_contig... or memory
>>> hotunplug). Likely they should either go to the MIGRATION section or to the
>>> PAGE ALLOCATOR? Maybe MIGRATION makes more sense. Thoughts?
>>
>> I mean it explicitly relates to migrate type and migration so seems to me
>> it ought to be in migration.
>>
>> Though migrate type + the machinary around it is a product of the physical
>> page allocator (I even cover it in the 'physical memory' section of the
>> book).
>>
>> I wonder if our soon-to-be page allocator maintainer Vlastimil has
>> thoughts? ;)
>>
>> I'd vote for migration though to be honest.
>
> I checked the code briefly and although migratetypes are related to
> migration, it seems rather page allocator code to me.
>
> In fact if I didn't miss these files, I would have included them when
> proposing the PAGE ALLOCATOR section.
> Zi Yan has a series on that topic now and is one of the R: in PAGE
> ALLOCATOR. What do you think?

I agree with Vlastimil that these two files belong to PAGE ALLOCATOR
section. Page isolation (actually should be pageblock isolation) is
doing work on pageblock migratetype, which IMHO is an important part
of anti-fragmentation mechanism for page allocation.

--
Best Regards,
Yan, Zi