linux-kernel - Re: [PATCH] relay: Remove unused relay_late_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a0548f8-02aa-4aab-a81b-2399c5393776@kernel.dk>
Date: Mon, 12 May 2025 07:27:51 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Jason Xing <kerneljasonxing@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, corbet@....net,
 linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 linux@...blig.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH] relay: Remove unused relay_late_setup_files

On 5/12/25 1:21 AM, Andy Shevchenko wrote:
> Then provide a roadmap on the upstreaming the necessary parts. Otherwise
> there is no room for a dead code in the Linux kernel. This is the rule:
> we do not add one, and we do not leave it dangling after removing the last
> user.

I don't pay a lot of attention to "roadmaps" - if the code is unused in
the kernel, it should go. Once other codes goes upstream that needs it,
it can get added back as a prep patch. Way too many times I've seen
promises and roadmaps for things that never materialize, and then the
code lingers for years before it's finally deleted.

So I'd say kill it with fire, bring it back if/when needed.

-- 
Jens Axboe