linux-kernel - Re: Re: [PATCH] ufs: core: Add HID support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250512133727.288-1-tanghuan@vivo.com>
Date: Mon, 12 May 2025 21:37:27 +0800
From: Huan Tang <tanghuan@...o.com>
To: peter.wang@...iatek.com
Cc: James.Bottomley@...senPartnership.com,
	alim.akhtar@...sung.com,
	avri.altman@....com,
	beanhuo@...ron.com,
	bvanassche@....org,
	ebiggers@...gle.com,
	gwendal@...omium.org,
	keosung.park@...sung.com,
	linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	luhongfei@...o.com,
	manivannan.sadhasivam@...aro.org,
	martin.petersen@...cle.com,
	minwoo.im@...sung.com,
	opensource.kernel@...o.com,
	quic_cang@...cinc.com,
	quic_nguyenb@...cinc.com,
	quic_ziqichen@...cinc.com,
	tanghuan@...o.com,
	viro@...iv.linux.org.uk,
	wenxing.cheng@...o.com
Subject: Re: Re: [PATCH] ufs: core: Add HID support

Hi peter sir,

Sorry for not replying in time. Thank you for your comments and guidance！
Based on your, Bart's and Arvi's suggestions, I submitted the v2 patch:

https://lore.kernel.org/all/20250512131519.138-1-tanghuan@vivo.com/

> Can just break? Because according the spec. 
> After the host reads the bHIDState value when it is 04h (Defrag
> Completion) or 05h (Defrag Not Required), the following parameters
> shall be initialized: 
> bHIDState value to 00h (Idle)
v2 patch does not use this

> Will have dead-lock when ufs_hid_enable_work_fn invoke
> ufshcd_rpm_get_sync?
v2 patch does not use this

> Please align the arrangement of these enums.
Already modified in v2 patch

> Please align the arrangement of these enums.
Already modified in v2 patch

> Please align the arrangement of these enums.
Already modified in v2 patch


Thanks
Huan