linux-kernel - Re: [PATCH] rslib: Add scheduling points during the test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250512135711.5307-1-ryotkkr98@gmail.com>
Date: Mon, 12 May 2025 22:57:11 +0900
From: Ryo Takakura <ryotkkr98@...il.com>
To: pmladek@...e.com
Cc: Jason@...c4.com,
	gregkh@...uxfoundation.org,
	john.ogness@...utronix.de,
	linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org,
	lkp@...el.com,
	oe-lkp@...ts.linux.dev,
	oliver.sang@...el.com,
	ryotkkr98@...il.com
Subject: Re: [PATCH] rslib: Add scheduling points during the test

On Mon, 12 May 2025 13:47:08 +0200, Petr Mladek wrote:
>On Sat 2025-05-10 10:35:15, Ryo Takakura wrote:
>> The test has been prone to softlockup but stayed unnoticed because
>> of the printk calls during the test resets the soflockup watchdog by
>> calling touch_nmi_watchdog(). With the commit b63e6f60eab4 ("serial:
>> 8250: Switch to nbcon console"), the printk calls no longer suppress
>> the softlockup and warnings can be observed more evidently that shows
>> the test needs more scheduling points.
>> 
>> Provide scheduling points by adding cond_resched() for each test
>> iteration on their up to/beyond error correction capacity.
>> 
>
>We should add here:
>
>Reported-by: kernel test robot <oliver.sang@...el.com>
>Closes: https://lore.kernel.org/oe-lkp/202501221029.fb0d574d-lkp@intel.com
>
>> Signed-off-by: Ryo Takakura <ryotkkr98@...il.com>
>
>Otherwise, it looks good to me:
>
>Reviewed-by: Petr Mladek <pmladek@...e.com>
>
>Thanks a lot for nailing it down.

I totally forgot the Reported-by and Closes, thanks!
I'll add them along with your Reviewed-by.

Sincerely,
Ryo Takakura

>Best Regards,
>Petr