linux-kernel - RE: [PATCH v4 05/31] fs/resctrl: Set up Kconfig options for telemetry events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB60839C0C7DEAE64DDAAF0E9EFC97A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Mon, 12 May 2025 14:19:53 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Chen, Yu C" <yu.c.chen@...el.com>
CC: "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>, Peter Newman <peternewman@...gle.com>, James Morse
	<james.morse@....com>, Dave Martin <Dave.Martin@....com>, Babu Moger
	<babu.moger@....com>, "Keshavamurthy, Anil S"
	<anil.s.keshavamurthy@...el.com>, Drew Fustini <dfustini@...libre.com>,
	Fenghua Yu <fenghuay@...dia.com>, "Wieczor-Retman, Maciej"
	<maciej.wieczor-retman@...el.com>, "Chatre, Reinette"
	<reinette.chatre@...el.com>
Subject: RE: [PATCH v4 05/31] fs/resctrl: Set up Kconfig options for telemetry
 events

> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 5a09acf41c8e..19107fdb4264 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -508,6 +508,7 @@ config X86_CPU_RESCTRL
> >     bool "x86 CPU resource control support"
> >     depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD)
> >     depends on MISC_FILESYSTEMS
> > +   select INTEL_AET_RESCTRL if (X86_64 && CPU_SUP_INTEL)
>
> Not sure if if it is expected, I got the following warning
> during compiling:
> WARNING: unmet direct dependencies detected for INTEL_AET_RESCTRL
>    Depends on [n]: X86_PLATFORM_DEVICES [=y] && INTEL_PMT_TELEMETRY [=n]
>    Selected by [y]:
>    - X86_CPU_RESCTRL [=y] && X86 [=y] && (CPU_SUP_INTEL [=y] ||
> CPU_SUP_AMD [=y]) && MISC_FILESYSTEMS [=y] && X86_64 [=y] &&
> CPU_SUP_INTEL [=y]
>
> I think this is because the INTEL_PMT_TELEMETRY is disabled.
> Does it make sense to add the dependency of INTEL_PMT_TELEMETRY
> to auto-select for INTEL_AET_RESCTRL?
>
> select INTEL_AET_RESCTRL if (X86_64 && CPU_SUP_INTEL && INTEL_PMT_TELEMETRY)

I'll try to get some proper solution once the OOBMSM driver updates are
upstream and I don't need to provide fake interfaces. Latest version of
those patches are here[1].

Those patches add the "PMT discovery driver" which is the part that provides
the intel_pmt_get_regions_by_feature() interface. Resctrl will need to depend
on (or select) INTEP_PMT_DISCOVERY=y

-Tony

[1] https://lore.kernel.org/all/20250430212106.369208-1-david.e.box@linux.intel.com/