linux-kernel - Re: [PATCH v2 3/6] arm64: dts: qcom: qcs615: Add mproc node for SEMP2P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f70013d1-6273-4ec9-b860-0d88cfe6f181@quicinc.com>
Date: Mon, 12 May 2025 11:17:16 +0800
From: Lijuan Gao <quic_lijuang@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        Konrad Dybcio <konradybcio@...nel.org>
CC: <kernel@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Kyle Deng <quic_chunkaid@...cinc.com>
Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: qcs615: Add mproc node for
 SEMP2P



在 5/9/2025 4:53 PM, Konrad Dybcio 写道:
> On 5/9/25 10:22 AM, Lijuan Gao wrote:
>>
>>
>> 在 5/8/2025 10:40 PM, Konrad Dybcio 写道:
>>> On 5/7/25 12:26 PM, Lijuan Gao wrote:
>>>> From: Kyle Deng <quic_chunkaid@...cinc.com>
>>>>
>>>> The Shared Memory Point to Point (SMP2P) protocol facilitates
>>>> communication of a single 32-bit value between two processors.
>>>> Add these two nodes for remoteproc enablement on QCS615 SoC.
>>>>
>>>> Signed-off-by: Kyle Deng <quic_chunkaid@...cinc.com>
>>>> Signed-off-by: Lijuan Gao <quic_lijuang@...cinc.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/qcs615.dtsi | 43 ++++++++++++++++++++++++++++++++++++
>>>>    1 file changed, 43 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>> index 7c377f3402c1..53661e3a852e 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>> @@ -332,6 +332,49 @@ mc_virt: interconnect-2 {
>>>>            qcom,bcm-voters = <&apps_bcm_voter>;
>>>>        };
>>>>    +    smp2p-adsp {
>>>> +        compatible = "qcom,smp2p";
>>>> +        qcom,smem = <443>, <429>;
>>>> +        interrupts = <GIC_SPI 172 IRQ_TYPE_EDGE_RISING>;
>>>> +        mboxes = <&apss_shared 26>;
>>>
>>> 26 will poke at the SLPI instead
>>
>> SLPI has not been enabled in QCS615, so the sensor will be in ADSP.  And 26 is being used dowstream, so it should be correct.
> 
> Please check in with the relevant folks and leave a comment such as
> 
> /* On this platform, bit 26 (normally SLPI) is repurposed for ADSP */
> 
> if it's indeed correct
> 
> Konrad

Yes, I have already confirmed the above information with the relevant 
folks. I will add this comment in the next patch.

-- 
Thx and BRs
Lijuan Gao