linux-kernel - Re: [PATCH v2 14/15] drm/mediatek: Add support for multiple mmsys in the one mediatek-drm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a917b57f4392e1cba5798d97da4c4b24f1a5e990.camel@mediatek.com>
Date: Tue, 13 May 2025 16:11:38 +0000
From: Paul-pl Chen (陳柏霖) <Paul-pl.Chen@...iatek.com>
To: CK Hu (胡俊光) <ck.hu@...iatek.com>
CC: "conor+dt@...nel.org" <conor+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, Sunny Shen (沈姍姍)
	<Sunny.Shen@...iatek.com>, Sirius Wang (王皓昱)
	<Sirius.Wang@...iatek.com>, Nancy Lin (林欣螢)
	<Nancy.Lin@...iatek.com>, Xiandong Wang (王先冬)
	<Xiandong.Wang@...iatek.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"fshao@...omium.org" <fshao@...omium.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "treapking@...omium.org" <treapking@...omium.org>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
Subject: Re: [PATCH v2 14/15] drm/mediatek: Add support for multiple mmsys in
 the one mediatek-drm driver

On Tue, 2025-03-25 at 03:44 +0000, CK Hu (胡俊光) wrote:
> On Fri, 2025-03-21 at 17:33 +0800, paul-pl.chen wrote:
> > From: Nancy Lin <nancy.lin@...iatek.com>
> > 
> > To support multiple mmsys instances in the one mediatek-drm
> > instance,
> > providing improved flexibility and scalability by the following
> > changes:
> > 
> > 1. Add DDP_COMPONENT_DRM_OVLSYS_ADAPTOR* to probe the
> >   ovlsys_adaptor drivers and support different mmsys composition.
> > 2. Added new component types MTK_DISP_VIRTUAL to support the
> >   routing to virtual display components.
> > 3. Added and adjusted the existed structure or interface to extend
> >   the support of multiple mmsys instances.
> > 4. Modified the component matching and binding logic to support
> >   multiple mmsys instances.
> > 
> > Signed-off-by: Nancy Lin <nancy.lin@...iatek.com>
> > Signed-off-by: Paul-pl Chen <paul-pl.chen@...iatek.com>
> > ---
> 
> [snip]
> 
> >  
> > +enum mtk_drm_mmsys {
> > +	DISPSYS0,
> > +	DISPSYS1,
> > +	OVLSYS0,
> > +	OVLSYS1,
> > +	MAX_MMSYS,
> > +};
> 
> Let ovlsys sub driver control OVLSYS0 and OVLSYS1, so mediatek drm
> driver would not see them and this patch is not necessary.
> 
> Regards,
> CK
> 
> 
Hi CK, 

The DRM Driver needs the distinguish between ovlsys0,
ovlsys1, dispsys0, dispsys1 to connect the main, ext, third
CRTC Paths.


"ovlsys sub driver control OVLSYS0 and OVLSYS1, so mediatek drm
driver would not see them and this patch" 

This is significant change, we will fix this modification at the 
next version.

 

Best, Paul
> 
> 
> 
>