linux-kernel - Re: [PATCH] extcon: Maxim MAX14526: avoid defined but not used warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGTfZH1aHVxB+BbJmP+2zCFvR81fGJgK8KBVyx3PkAf3ATatXQ@mail.gmail.com>
Date: Wed, 14 May 2025 01:35:10 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Svyatoslav Ryhel <clamor95@...il.com>, 
	Chanwoo Choi <cw00.choi@...sung.com>, MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] extcon: Maxim MAX14526: avoid defined but not used warning

Hi,

In order to keep the consistent style of extcon patches,
I'd like you to edit the patch title as following:
- As-Is: extcon: Maxim MAX14526: avoid defined but not used warning
- To-Be: extcon: max14526: avoid defined but not used warning

On Tue, May 13, 2025 at 9:23 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> SIMPLE_PM_DEV_OPS() is deprecated according to <linux/pm.h>.
> Use DEFINE_SIMPLE_PM_DEV_OPS() instead. This avoids a build warning
> when CONFIG_PM is not enabled:
>
> drivers/extcon/extcon-max14526.c:265:12: warning: ‘max14526_resume’ defined but not used [-Wunused-function]
>   265 | static int max14526_resume(struct device *dev)
>
> Fixes: c2aeb8647e53 ("extcon: Add basic support for Maxim MAX14526 MUIC")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Svyatoslav Ryhel <clamor95@...il.com>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> ---
>  drivers/extcon/extcon-max14526.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20250512.orig/drivers/extcon/extcon-max14526.c
> +++ linux-next-20250512/drivers/extcon/extcon-max14526.c
> @@ -272,7 +272,7 @@ static int max14526_resume(struct device
>         return 0;
>  }
>
> -static SIMPLE_DEV_PM_OPS(max14526_pm_ops, NULL, max14526_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(max14526_pm_ops, NULL, max14526_resume);
>
>  static const struct of_device_id max14526_match[] = {
>         { .compatible = "maxim,max14526" },
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics