[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4tjbyzn22sctrv7sdn7aetl7vse4epvqqctqgtx73kkh46njbv@lisa3ejipu62>
Date: Tue, 13 May 2025 18:39:10 +0200
From: Benjamin Tissoires <bentiss@...nel.org>
To: Jiri Kosina <jikos@...nel.org>
Cc: Werner Sembach <wse@...edocomputers.com>, linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Disable touchpad on firmware level while not in use
On Apr 24 2025, Jiri Kosina wrote:
> On Tue, 4 Mar 2025, Werner Sembach wrote:
>
> > > Using the new on_hid_hw_open and on_hid_hw_close functions to disable the
> > > touchpad on firmware level while not being in use.
> > >
> > > This safes some battery and triggers touchpad-disabled-leds hardwired to
> > > the touchpads firmware, that exist for example on some TongFang barebones.
> > >
> > > For a lengthy discussion with all the details see
> > > https://gitlab.freedesktop.org/libinput/libinput/-/issues/558
> >
> > Any comments if this is a good idea or not?
>
> Sorry for the delay.
>
> To me this looks like generally a good idea; Benjamin, any comments on the
> hid-mt part?
Looks good to me, though my CI is now taking way more time because it's
not expecting to receive data from the device once the initial setup is
done.
>
> BTW you'd need to adjust the Subject line of the patches to conform to the
> subsystem style (i.e. HID: core: ....)
Amended locally and pushed (see the notification email).
Cheers,
Benjamin
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
Powered by blists - more mailing lists