linux-kernel - Re: [PATCH 2/2] f2fs: add f2fs_bug_on() in f2fs_quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44e7161a-0da8-442b-9849-7fe7e51c83f3@kernel.org>
Date: Tue, 13 May 2025 10:45:22 +0800
From: Chao Yu <chao@...nel.org>
To: Jaegeuk Kim <jaegeuk@...nel.org>
Cc: chao@...nel.org, linux-f2fs-devel@...ts.sourceforge.net,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read()

On 5/12/25 23:27, Jaegeuk Kim wrote:
> On 05/12, Chao Yu wrote:
>> mapping_read_folio_gfp() will return a folio, it should always be
>> uptodate, let's check folio uptodate status to detect any potenial
>> bug.
> 
> If it's supposed to be uptodate, can you add f2fs_bug_on() only?

Sure.

Thanks,

> 
>>
>> Signed-off-by: Chao Yu <chao@...nel.org>
>> ---
>>  fs/f2fs/super.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 0ee783224953..ea207a9edc10 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -2973,6 +2973,17 @@ static ssize_t f2fs_quota_read(struct super_block *sb, int type, char *data,
>>  			goto repeat;
>>  		}
>>  
>> +		/*
>> +		 * should never happen, just leave f2fs_bug_on() here to catch
>> +		 * any potential bug.
>> +		 */
>> +		if (unlikely(!folio_test_uptodate(folio))) {
>> +			f2fs_folio_put(folio, true);
>> +			set_sbi_flag(F2FS_SB(sb), SBI_QUOTA_NEED_REPAIR);
>> +			f2fs_bug_on(F2FS_SB(sb), 1);
>> +			return -EIO;
>> +		}
>> +
>>  		memcpy_from_folio(data, folio, offset, tocopy);
>>  		f2fs_folio_put(folio, true);
>>  
>> -- 
>> 2.49.0