linux-kernel - RE: [PATCH v2 net-next] net: enetc: convert to ndo_hwtstamp_get() and ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB851094997FBB7BDFDA6EDADB8896A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Tue, 13 May 2025 02:47:52 +0000
From: Wei Fang <wei.fang@....com>
To: Vladimir Oltean <vladimir.oltean@....com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: Köry Maincent <kory.maincent@...tlin.com>, Clark Wang
	<xiaoning.wang@....com>, Andrew Lunn <andrew@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Claudiu Manoil
	<claudiu.manoil@....com>, Simon Horman <horms@...nel.org>, Richard Cochran
	<richardcochran@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 net-next] net: enetc: convert to ndo_hwtstamp_get() and
 ndo_hwtstamp_set()

> New timestamping API was introduced in commit 66f7223039c0 ("net: add
> NDOs for configuring hardware timestamping") from kernel v6.6. It is
> time to convert the ENETC driver to the new API, so that the
> ndo_eth_ioctl() path can be removed completely.
> 
> Move the enetc_hwtstamp_get() and enetc_hwtstamp_set() calls away from
> enetc_ioctl() to dedicated net_device_ops for the LS1028A PF and VF
> (NETC v4 does not yet implement enetc_ioctl()), adapt the prototypes and
> export these symbols (enetc_ioctl() is also exported).
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> v1->v2:
> - remove shim definitions of enetc_hwtstamp_set() and
>   enetc_hwtstamp_get(), replace them with "return -EOPNOTSUPP" if
>   CONFIG_FSL_ENETC_PTP_CLOCK is not enabled.
> - delete unnecessary config->flags = 0 assignment
> 

ENETC v4 can add timestamp support based on these two new
interfaces, thanks.

Reviewed-by: Wei Fang <wei.fang@....com>