linux-kernel - Re: [PATCH RESEND] nios2: Replace strcpy() with strscpy() and simplify setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d147f81-12cc-41f3-ab40-6fb198541e3e@kernel.org>
Date: Mon, 12 May 2025 21:50:52 -0500
From: Dinh Nguyen <dinguyen@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: linux-hardening@...r.kernel.org, Kees Cook <kees@...nel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] nios2: Replace strcpy() with strscpy() and
 simplify setup_cpuinfo()

On 5/9/25 11:38, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
> 
> Since the destination buffer has a fixed length, strscpy() automatically
> determines its size using sizeof() when the size argument is omitted.
> This makes the explicit size argument unnecessary - remove it.
> 
> Now, combine both if-else branches using strscpy() and the same buffer
> into a single statement to simplify the code.
> 
> No functional changes intended.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Cc: linux-hardening@...r.kernel.org
> Reviewed-by: Kees Cook <kees@...nel.org>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>   arch/nios2/kernel/cpuinfo.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 

Applied!

Thanks,
Dinh