linux-kernel - Re: [PATCH 3/4] PM / devfreq: Remove redundant devfreq_get_freq_range() calling in devfreq_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGTfZH1q60p5yhgm=0r+X6=NLbjidwGdL6AB=E2LgwP3kR15Jg@mail.gmail.com>
Date: Wed, 14 May 2025 02:41:02 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: Lifeng Zheng <zhenglifeng1@...wei.com>
Cc: myungjoo.ham@...sung.com, kyungmin.park@...sung.com, cw00.choi@...sung.com, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, linuxarm@...wei.com, 
	jonathan.cameron@...wei.com, zhanjie9@...ilicon.com, lihuisong@...wei.com, 
	yubowen8@...wei.com, cenxinghai@...artners.com
Subject: Re: [PATCH 3/4] PM / devfreq: Remove redundant devfreq_get_freq_range()
 calling in devfreq_add_device()

Hi,

Applied it. Thanks

On Mon, Apr 21, 2025 at 12:01 PM Lifeng Zheng <zhenglifeng1@...wei.com> wrote:
>
> The calling of devfreq_get_freq_range() in devfreq_add_device() is
> redundant because min_freq and max_freq are never used. Remove it.
>
> Signed-off-by: Lifeng Zheng <zhenglifeng1@...wei.com>
> ---
>  drivers/devfreq/devfreq.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 2810c84b9f8a..18e3f7e063a4 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -804,7 +804,6 @@ struct devfreq *devfreq_add_device(struct device *dev,
>  {
>         struct devfreq *devfreq;
>         struct devfreq_governor *governor;
> -       unsigned long min_freq, max_freq;
>         int err = 0;
>
>         if (!dev || !profile || !governor_name) {
> @@ -872,8 +871,6 @@ struct devfreq *devfreq_add_device(struct device *dev,
>                 goto err_dev;
>         }
>
> -       devfreq_get_freq_range(devfreq, &min_freq, &max_freq);
> -
>         devfreq->suspend_freq = dev_pm_opp_get_suspend_opp_freq(dev);
>         devfreq->opp_table = dev_pm_opp_get_opp_table(dev);
>         if (IS_ERR(devfreq->opp_table))
> --
> 2.33.0
>
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics