linux-kernel - Re: [PATCH] params: Add support for static keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4700ad8-1e6d-4f57-b160-e7b6d172ef60@csgroup.eu>
Date: Tue, 13 May 2025 19:51:57 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Kent Overstreet <kent.overstreet@...ux.dev>, linux-kernel@...r.kernel.org
Cc: Luis Chamberlain <mcgrof@...nel.org>, Petr Pavlu <petr.pavlu@...e.com>,
 Sami Tolvanen <samitolvanen@...gle.com>, Daniel Gomez
 <da.gomez@...sung.com>, linux-modules@...r.kernel.org
Subject: Re: [PATCH] params: Add support for static keys



Le 10/05/2025 à 23:01, Kent Overstreet a écrit :
> Static keys can now be a module parameter, e.g.
> 
> module_param_named(foo, foo.key, static_key_t, 0644)
> 
> bcachefs is now using this.
> 
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Petr Pavlu <petr.pavlu@...e.com>
> Cc: Sami Tolvanen <samitolvanen@...gle.com>
> Cc: Daniel Gomez <da.gomez@...sung.com>
> Cc: linux-modules@...r.kernel.org
> Signed-off-by: Kent Overstreet <kent.overstreet@...ux.dev>
> ---
>   include/linux/jump_label.h  |  2 ++
>   include/linux/moduleparam.h |  6 ++++++
>   kernel/params.c             | 35 +++++++++++++++++++++++++++++++++++
>   3 files changed, 43 insertions(+)
> 
> diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
> index fdb79dd1ebd8..0fc9b71db56f 100644
> --- a/include/linux/jump_label.h
> +++ b/include/linux/jump_label.h
> @@ -107,6 +107,8 @@ struct static_key {
>   #endif	/* CONFIG_JUMP_LABEL */
>   };
>   
> +typedef struct static_key static_key_t;
> +

Please read https://docs.kernel.org/process/coding-style.html#typedefs

I can't see the reason for a new typedef here. If there is a valid 
reason please explain in the commit message.

Christophe