linux-kernel - Re: [PATCH] statmount: update STATMOUNT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a42a57a341ce02c9d2a52ab9f709ce45e19f7bb4.camel@kernel.org>
Date: Tue, 13 May 2025 15:08:37 -0400
From: Jeff Layton <jlayton@...nel.org>
To: "Dmitry V. Levin" <ldv@...ace.io>, Christian Brauner <brauner@...nel.org>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] statmount: update STATMOUNT_SUPPORTED macro

On Mon, 2025-05-12 at 01:49 +0300, Dmitry V. Levin wrote:
> According to commit 8f6116b5b77b ("statmount: add a new supported_mask
> field"), STATMOUNT_SUPPORTED macro shall be updated whenever a new flag
> is added.
> 
> Fixes: 7a54947e727b ("Merge patch series "fs: allow changing idmappings"")
> Signed-off-by: Dmitry V. Levin <ldv@...ace.io>
> ---
>  fs/namespace.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 1b466c54a357..e321f8bae914 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -5804,7 +5804,9 @@ static int grab_requested_root(struct mnt_namespace *ns, struct path *root)
>  			     STATMOUNT_SB_SOURCE | \
>  			     STATMOUNT_OPT_ARRAY | \
>  			     STATMOUNT_OPT_SEC_ARRAY | \
> -			     STATMOUNT_SUPPORTED_MASK)
> +			     STATMOUNT_SUPPORTED_MASK | \
> +			     STATMOUNT_MNT_UIDMAP | \
> +			     STATMOUNT_MNT_GIDMAP)
>  
>  static int do_statmount(struct kstatmount *s, u64 mnt_id, u64 mnt_ns_id,
>  			struct mnt_namespace *ns)

I guess this patch and the MNT_UID/GIDMAP patches went in around the
same time, and I missed adding them to the mask since I didn't have
that patch in the tree I was working against at the time.

This is probably better for the fixes tag though:

    8f6116b5b77b statmount: add a new supported_mask field

...given that this patch went in just before it.

    37c4a9590e1e statmount: allow to retrieve idmappings

Either way:

Reviewed-by: Jeff Layton <jlayton@...nel.org>