linux-kernel - Re: [PATCH] net: bcmgenet: tidy up stats, expose more stats in ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA+QEuR0BDAwrboJrGkHf4y0FGoUef4jcjpz9wx0uJn-t0sUyw@mail.gmail.com>
Date: Tue, 13 May 2025 20:20:51 +0100
From: Zak Kemble <zakkemble@...il.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: Doug Berger <opendmb@...il.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bcmgenet: tidy up stats, expose more stats in ethtool

Heya, I've split up the changes and updated the stats reporting to use
ndo_get_stats64 etc. here -
https://lore.kernel.org/all/20250513144107.1989-1-zakkemble@gmail.com/


On Mon, 12 May 2025 at 15:35, Florian Fainelli
<florian.fainelli@...adcom.com> wrote:
>
>
>
> On 5/11/2025 11:40 PM, zakkemble@...il.com wrote:
> > From: Zak Kemble <zakkemble@...il.com>
> >
> > This patch exposes more statistics counters in ethtool and tidies up the
> > counters so that they are all per-queue. The netdev counters are now only
> > updated synchronously in bcmgenet_get_stats instead of a mix of sync/async
> > throughout the driver. Hardware discarded packets are now counted in their
> > own missed stat instead of being lumped in with general errors.
> >
> > Signed-off-by: Zak Kemble <zakkemble@...il.com>
>
> If you are making changes to the driver around statistics, I would
> rather you modernize the driver to report statistics according to how it
> should be done, that is following what bcmasp2 does. Thank you.
> --
> Florian
>