[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aCOu-CoYBcX3LNN8@x1>
Date: Tue, 13 May 2025 17:43:36 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: James Clark <james.clark@...aro.org>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
Namhyung Kim <namhyung@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Ian Rogers <irogers@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
Kan Liang <kan.liang@...ux.intel.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-perf-users@...r.kernel.org
Subject: Re: make -C tools/perf build-test failing on aarch64
On Tue, May 13, 2025 at 11:05:16AM +0100, James Clark wrote:
> On 11/05/2025 18:46, James Clark wrote:
> > On 10/05/2025 2:42 am, Arnaldo Carvalho de Melo wrote:
> > > I noticed that upstream is failing on aarch64:
<SNIP>
> > > I think this is related to:
> > > commit bfb713ea53c746b07ae69fe97fa9b5388e4f34f9 (perf-tools)
> > > Author: James Clark <james.clark@...aro.org>
> > > Date: Thu Apr 17 14:55:50 2025 +0100
> > > perf tools: Fix arm64 build by generating unistd_64.h
> > > Can you please take a look?
> > Hmm yeah looks like it's caused by that. I'm travelling tomorrow but
> > I'll try to take a look.
> Sent the fix, hopefully 3rd time lucky.
Thanks a bunch! It seems we will not need a 4th. :-)
> I know there is the build-test target but I had let my setup bitrot so I
> wasn't running it. I don't know if you have ever shared any of your docker
> containers that you use for build testing?
I keep them at:
https://github.com/acmel/linux-tools-container-builds
The README should be enough to get you going, if you find some
difficulty, please lemme know.
I use this since forever and made them available at github when Daniel
Bristot started maintaining his tools in the kernels sources, the idea
was for him to also use to test build his tools.
It'll be great if you find them useful and, better, wire it up to some
sort of CI you're using.
It does a subset of what 'make -C tools/perf build-test' does, but the
idea for them is to switch to do the full build-test target and also to
run 'perf test', that would be restricted to whatever perms a the
containers are given.
Nowadays with parallel 'perf test' and it having being polished to work
with less perms, that seems like a worthy goal to pursue.
> I will also try to get that target added to our CI. We're only running a
> normal build and then "perf test" there.
That will be really nice of you, wiring up these things so that when I
run it all goes as expected will be great!
- Arnaldo
Powered by blists - more mailing lists