linux-kernel - Re: [PATCH 1/8] securityfs: don't pin dentries twice, once is enough...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhR7-R20Q7A8RGCAMvBxNyUXOcj-dHAcMi-GAyVsxQZ7aQ@mail.gmail.com>
Date: Tue, 13 May 2025 19:13:07 -0400
From: Paul Moore <paul@...l-moore.com>
To: linux-security-module@...r.kernel.org
Cc: Al Viro <viro@...iv.linux.org.uk>, alexjlzheng@...il.com, jmorris@...ei.org, 
	serge@...lyn.com, greg@...ah.com, chrisw@...l.org, 
	linux-kernel@...r.kernel.org, Jinliang Zheng <alexjlzheng@...cent.com>
Subject: Re: [PATCH 1/8] securityfs: don't pin dentries twice, once is enough...

On Fri, May 9, 2025 at 12:38 AM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> From 5c463d47c814e16adb6e997a05ca5625df41152d Mon Sep 17 00:00:00 2001
> From: Al Viro <viro@...iv.linux.org.uk>
> Date: Thu, 8 May 2025 23:38:01 -0400
> Subject: [PATCH 1/8] securityfs: don't pin dentries twice, once is enough...
>
> incidentally, securityfs_recursive_remove() is broken without that -
> it leaks dentries, since simple_recursive_removal() does not expect
> anything of that sort.  It could be worked around by dput() in
> remove_one() callback, but it's easier to just drop that double-get
> stuff.
>
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
>  security/inode.c | 2 --
>  1 file changed, 2 deletions(-)

Replying with a lore link to the associated discussion and warning so
we have some record of it in the LSM patchwork.

https://lore.kernel.org/linux-security-module/20250509044613.GT2023217@ZenIV/

-- 
paul-moore.com