linux-kernel - Re: [PATCH v9 4/5] tpm: Add a driver for Loongson TPM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5f868d2-295d-b1ab-904a-9e5c032037f0@loongson.cn>
Date: Tue, 13 May 2025 15:20:40 +0800
From: Qunqin Zhao <zhaoqunqin@...ngson.cn>
To: jarkko@...nel.org, Stefano Garzarella <sgarzare@...hat.com>
Cc: lee@...nel.org, herbert@...dor.apana.org.au, davem@...emloft.net,
 peterhuewe@....de, linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
 linux-crypto@...r.kernel.org, jgg@...pe.ca, linux-integrity@...r.kernel.org,
 pmenzel@...gen.mpg.de, Yinggang Gu <guyinggang@...ngson.cn>,
 Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH v9 4/5] tpm: Add a driver for Loongson TPM device


Hi, Jarkko and Stefano

在 2025/5/6 上午11:19, Qunqin Zhao 写道:
> Loongson Security Engine supports random number generation, hash,
> symmetric encryption and asymmetric encryption. Based on these
> encryption functions, TPM2 have been implemented in the Loongson
> Security Engine firmware. This driver is responsible for copying data
> into the memory visible to the firmware and receiving data from the
> firmware.
>
> Co-developed-by: Yinggang Gu <guyinggang@...ngson.cn>
> Signed-off-by: Yinggang Gu <guyinggang@...ngson.cn>
> Signed-off-by: Qunqin Zhao <zhaoqunqin@...ngson.cn>
> Reviewed-by: Huacai Chen <chenhuacai@...ngson.cn>
> Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
> ---
> v9: "tpm_loongson_driver" --> "tpm_loongson"
>      "depends on CRYPTO_DEV_LOONGSON_SE" --> "depends on MFD_LOONGSON_SE"
>
...
> +static int tpm_loongson_recv(struct tpm_chip *chip, u8 *buf, size_t count)
> +{
> +	struct loongson_se_engine *tpm_engine = dev_get_drvdata(&chip->dev);
> +	struct tpm_loongson_cmd *cmd_ret = tpm_engine->command_ret;

if (cmd_ret->data_len > count)
         return -EIO;

> +
> +	memcpy(buf, tpm_engine->data_buffer, cmd_ret->data_len);
> +
> +	return cmd_ret->data_len;
> +}
> +
> +static int tpm_loongson_send(struct tpm_chip *chip, u8 *buf, size_t count)
> +{
> +	struct loongson_se_engine *tpm_engine = dev_get_drvdata(&chip->dev);
> +	struct tpm_loongson_cmd *cmd = tpm_engine->command;
> +
if (count > tpm_engine->buffer_size)

         return -E2BIG;

> +	cmd->data_len = count;
> +	memcpy(tpm_engine->data_buffer, buf, count);
> +
> +	return loongson_se_send_engine_cmd(tpm_engine);
> +}

Thanks for your comments,

Qunqin.