linux-kernel - Re: [PATCH 1/2] w1: ds2406: use crc16() instead of crc16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <271da1c2-c322-4568-b484-c368e5e0ae7c@kernel.org>
Date: Tue, 13 May 2025 09:52:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>, linux-kernel@...r.kernel.org
Cc: linux-crypto@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH 1/2] w1: ds2406: use crc16() instead of crc16_byte() loop

On 13/05/2025 04:21, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Instead of looping through each byte and calling crc16_byte(), instead
> just call crc16() on the whole buffer.  No functional change.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>  drivers/w1/slaves/w1_ds2406.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof