linux-kernel - Re: [PATCH 2/2] USB: xhci: use urb hcpriv mempool for private data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd601d4f-566b-4fd1-b13e-b7bf8bb59507@suse.com>
Date: Tue, 13 May 2025 11:00:01 +0200
From: Oliver Neukum <oneukum@...e.com>
To: David Wang <00107082@....com>, Oliver Neukum <oneukum@...e.com>
Cc: mathias.nyman@...el.com, gregkh@...uxfoundation.org,
 stern@...land.harvard.edu, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] USB: xhci: use urb hcpriv mempool for private data

Hi,

On 13.05.25 10:31, David Wang wrote:
  
> No, I don't think which HC the URB was last used for concerns here.
> A URB cannot be used by two HC at the same time, as long as this hold, I don't see reason
>   worrying about who use this private data before.
> 
> This patch for xhci dose not assume which HC use the private data mempool  previously, nor
> should other HCs.

OK, I need to correct myself.
Though I have to ask in the long run what happens
if two HCDs need to allocate the mempool differently.
But for now it will work.

> Or, do I misunderstand your comments?

No. The problem is with the first patch in the series.
Basically you need to pass mem_flags from usb_submit_urb()
to urb_hcpriv_mempool_zalloc() and use it.

	Regards
		Oliver