linux-kernel - Re: [PATCH v8 02/11] mfd: Add max7360 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250513093107.GC2936510@google.com>
Date: Tue, 13 May 2025 10:31:07 +0100
From: Lee Jones <lee@...nel.org>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Kamel Bouhara <kamel.bouhara@...tlin.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	Michael Walle <mwalle@...nel.org>, Mark Brown <broonie@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-input@...r.kernel.org, linux-pwm@...r.kernel.org,
	Grégory Clement <gregory.clement@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v8 02/11] mfd: Add max7360 support

On Tue, 13 May 2025, Mathieu Dubois-Briand wrote:

> On Mon May 12, 2025 at 11:21 AM CEST, Andy Shevchenko wrote:
> > On Fri, May 09, 2025 at 11:14:36AM +0200, mathieu.dubois-briand@...tlin.com wrote:
> >
> >> +#define MAX7360_REG_GPIO_LAST		0x5F
> >
> >> +#define MAX7360_FIFO_EMPTY		0x3f
> >> +#define MAX7360_FIFO_OVERFLOW		0x7f
> >
> > Please, be consistent in style of the values.
> 
> Is your point about the alignment of the values? Most of these are
> aligned on column 41, including the ones above. I just have an exception
> with MAX7360_PORT_CFG_*, as they are a bit too long. But as we are using
> tabs here, indentation appears a bit broken in the patch.

I believe the point was in reference to capitalisation.

-- 
Lee Jones [李琼斯]