linux-kernel - Re: [PATCH] mfd: Remove node variables that are unused with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250513104518.GA2811486@ax162>
Date: Tue, 13 May 2025 12:45:18 +0200
From: Nathan Chancellor <nathan@...nel.org>
To: Lee Jones <lee@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Jiri Slaby <jirislaby@...nel.org>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Andreas Kemnade <andreas@...nade.info>,
	Kevin Hilman <khilman@...libre.com>,
	Roger Quadros <rogerq@...nel.org>, Tony Lindgren <tony@...mide.com>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] mfd: Remove node variables that are unused with
 CONFIG_OF=n

On Tue, May 13, 2025 at 10:47:26AM +0100, Lee Jones wrote:
> On Thu, 08 May 2025, Nathan Chancellor wrote:
> 
> > A recent cleanup introduced a few instances of -Wunused-variable in
> > configurations without CONFIG_OF because of_fwnode_handle() does not
> > reference its argument in that case:
> > 
> >   drivers/mfd/twl4030-irq.c: In function 'twl4030_init_irq':
> >   drivers/mfd/twl4030-irq.c:679:46: warning: unused variable 'node' [-Wunused-variable]
> >     679 |         struct                  device_node *node = dev->of_node;
> >         |                                              ^~~~
> >   drivers/mfd/max8925-core.c: In function 'max8925_irq_init':
> >   drivers/mfd/max8925-core.c:659:29: warning: unused variable 'node' [-Wunused-variable]
> >     659 |         struct device_node *node = chip->dev->of_node;
> >         |                             ^~~~
> >   drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
> >   drivers/mfd/88pm860x-core.c:576:29: warning: unused variable 'node' [-Wunused-variable]
> >     576 |         struct device_node *node = i2c->dev.of_node;
> >         |                             ^~~~
> > 
> > Use the value of these variables as the argument to of_fwnode_handle()
> > directly, clearing up the warnings.
> > 
> > Fixes: e3d44f11da04 ("mfd: Switch to irq_domain_create_*()")
> > Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> > ---
> >  drivers/mfd/88pm860x-core.c | 5 ++---
> >  drivers/mfd/max8925-core.c  | 5 ++---
> >  drivers/mfd/twl4030-irq.c   | 5 ++---
> >  3 files changed, 6 insertions(+), 9 deletions(-)
> 
> Doesn't apply.  Which base commit / repo / branch are you using?

-tip's irq/cleanups branch:

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/log/?h=irq/cleanups

This change has both a base commit and a Fixes tag and you were on Cc,
not To. Is there anything else I can do (aside from a note in the
scissor area) to signal that you don't need to handle this change?

Cheers,
Nathan