linux-kernel - Re: [PATCH V3 RESEND 1/2] dt-bindings: spi: tegra: Document IOMMU property for Tegra234 QSPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250513-implode-half-0c3ffcf6d3f5@wendy>
Date: Tue, 13 May 2025 11:59:38 +0100
From: Conor Dooley <conor.dooley@...rochip.com>
To: Jon Hunter <jonathanh@...dia.com>
CC: Conor Dooley <conor@...nel.org>, Vishwaroop A <va@...dia.com>,
	<krzk@...nel.org>, <broonie@...nel.org>, <robh@...nel.org>,
	<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <thierry.reding@...il.com>,
	<skomatineni@...dia.com>, <ldewangan@...dia.com>, <kyarlagadda@...dia.com>,
	<smangipudi@...dia.com>, <bgriffis@...dia.com>, <linux-spi@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 RESEND 1/2] dt-bindings: spi: tegra: Document IOMMU
 property for Tegra234 QSPI

On Tue, May 13, 2025 at 11:19:05AM +0100, Jon Hunter wrote:

> > > +  - $ref: spi-controller.yaml#
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          const: nvidia,tegra234-qspi
> > 
> > > +    then:
> > > +      properties:
> > > +        iommus: true
> > 
> > This is a NOP, no?
> > Just invert the case above and drop a clause.
> 
> 
> Yes that's true. So just to confirm, your preference is this ...
> 
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> index 04d3b1a47392..c45511e9a9ed 100644
> --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> @@ -74,11 +74,13 @@ allOf:
>    - if:
>        properties:
>          compatible:
> -          const: nvidia,tegra234-qspi
> +          contains:
> +            enum:
> +              - nvidia,tegra210-qspi
> +              - nvidia,tegra186-qspi
> +              - nvidia,tegra194-qspi
> +              - nvidia,tegra241-qspi
>      then:
> -      properties:
> -        iommus: true
> -    else:
>        properties:
>          iommus: false

You can just invert the condition directly with a not:,
so "if: properties: compatible: not: contains:" should do the trick.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)