[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20250513123732.3041577-1-ruc_gongyuanjun@163.com>
Date: Tue, 13 May 2025 20:37:32 +0800
From: Yuanjun Gong <ruc_gongyuanjun@....com>
To: Sebastian Reichel <sre@...nel.org>,
linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Yuanjun Gong <ruc_gongyuanjun@....com>
Subject: [PATCH 1/1] power: return the correct error code
In POWER_SUPPLY_PROP_MODEL_NAME branch of max1720x_battery_get_property(),
program would return -ENODEV out of FIELD_GET error, but it's better also
considering the error code returned by regmap_read() in case it fails.
Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@....com>
---
drivers/power/supply/max1720x_battery.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/power/supply/max1720x_battery.c b/drivers/power/supply/max1720x_battery.c
index ea3912fd1de8..12ecb1f40fe1 100644
--- a/drivers/power/supply/max1720x_battery.c
+++ b/drivers/power/supply/max1720x_battery.c
@@ -426,6 +426,8 @@ static int max1720x_battery_get_property(struct power_supply *psy,
break;
case POWER_SUPPLY_PROP_MODEL_NAME:
ret = regmap_read(info->regmap, MAX172XX_DEV_NAME, ®_val);
+ if (ret)
+ return ret;
reg_val = FIELD_GET(MAX172XX_DEV_NAME_TYPE_MASK, reg_val);
if (reg_val == MAX172XX_DEV_NAME_TYPE_MAX17201)
val->strval = max17201_model;
--
2.25.1
Powered by blists - more mailing lists