linux-kernel - Re: [PATCH] dma-buf: insert memory barrier before updating num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9652f863-5e60-4c5a-acd1-f897c1148105@amd.com>
Date: Wed, 14 May 2025 15:33:10 +0200
From: Christian König <christian.koenig@....com>
To: Hyejeong Choi <hjeong.choi@...sung.com>, sumit.semwal@...aro.org
Cc: linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma-buf: insert memory barrier before updating num_fences

On 5/13/25 04:06, Hyejeong Choi wrote:
> smp_store_mb() inserts memory barrier after storing operation.
> It is different with what the comment is originally aiming so Null
> pointer dereference can be happened if memory update is reordered.
> 
> Signed-off-by: Hyejeong Choi <hjeong.choi@...sung.com>

I've reviewed, add CC stable and Fixes tags and pushed it to drm-misc-fixes.

Thanks,
Christian.

> ---
>  drivers/dma-buf/dma-resv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
> index 5f8d010516f0..b1ef4546346d 100644
> --- a/drivers/dma-buf/dma-resv.c
> +++ b/drivers/dma-buf/dma-resv.c
> @@ -320,8 +320,9 @@ void dma_resv_add_fence(struct dma_resv *obj, struct dma_fence *fence,
>  	count++;
>  
>  	dma_resv_list_set(fobj, i, fence, usage);
> -	/* pointer update must be visible before we extend the num_fences */
> -	smp_store_mb(fobj->num_fences, count);
> +	/* fence update must be visible before we extend the num_fences */
> +	smp_wmb();
> +	fobj->num_fences = count;
>  }
>  EXPORT_SYMBOL(dma_resv_add_fence);
>  
> 
>