[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20250514094849.cac2bd27d047fbc1ae6ba74f@hugovil.com>
Date: Wed, 14 May 2025 09:48:49 -0400
From: Hugo Villeneuve <hugo@...ovil.com>
To: Biju Das <biju.das.jz@...renesas.com>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong
<neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
laurent.pinchart <laurent.pinchart@...asonboard.com>, Jonas Karlman
<jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, David Airlie
<airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Magnus
Damm <magnus.damm@...il.com>, Hugo Villeneuve <hvilleneuve@...onoff.com>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: display: bridge: renesas,dsi: allow
properties from dsi-controller
On Wed, 14 May 2025 06:00:28 +0000
Biju Das <biju.das.jz@...renesas.com> wrote:
> Hi Hugo Villeneuve,
>
> Thanks for your patch.
>
> > -----Original Message-----
> > From: Hugo Villeneuve <hugo@...ovil.com>
> > Sent: 13 May 2025 17:23
> > Subject: [PATCH] dt-bindings: display: bridge: renesas,dsi: allow properties from dsi-controller
> >
> > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> >
> > Allow to inherit valid properties from the dsi-controller. This fixes the following warning when
> > adding a panel property:
> >
> > rzg2lc.dtb: dsi@...50000: '#address-cells', '#size-cells', 'panel@0' do not
> > match any of the regexes: 'pinctrl-[0-9]+'
> > from schema $id:
> > http://devicetree.org/schemas/display/bridge/renesas,dsi.yaml#
> >
> > Also add a panel property to the example.
> >
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > ---
> > .../bindings/display/bridge/renesas,dsi.yaml | 21 +++++++++++++++++--
> > 1 file changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > b/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > index e08c24633926b..e0906a46fb118 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > @@ -128,14 +128,17 @@ required:
> > - power-domains
> > - ports
> >
> > -additionalProperties: false
> > +unevaluatedProperties: false
> >
> > examples:
> > - |
> > + #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/clock/r9a07g044-cpg.h>
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> >
> > dsi0: dsi@...50000 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > compatible = "renesas,r9a07g044-mipi-dsi", "renesas,rzg2l-mipi-dsi";
> > reg = <0x10850000 0x20000>;
> > interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>, @@ -160,6 +163,20 @@ examples:
> > reset-names = "rst", "arst", "prst";
> > power-domains = <&cpg>;
> >
> > + panel@0 {
> > + compatible = "rocktech,jh057n00900";
> > + reg = <0>;
> > + vcc-supply = <®_2v8_p>;
> > + iovcc-supply = <®_1v8_p>;
> > + reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
> > +
> > + port {
> > + panel_in: endpoint {
> > + remote-endpoint = <&dsi0_out>;
> > + };
> > + };
> > + };
> > +
> > ports {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > @@ -175,7 +192,7 @@ examples:
> > reg = <1>;
> > dsi0_out: endpoint {
> > data-lanes = <1 2 3 4>;
> > - remote-endpoint = <&adv7535_in>;
> > + remote-endpoint = <&panel_in>;
>
> Can we make panel example as separate one?
>
> 1) One example for using bridge device
> 2) One example for using direct panel.
Hi Biju,
sure, will do in V2.
Thank you,
Hugo.
>
> Cheers,
> Biju
>
> > };
> > };
> > };
> >
> > base-commit: e9565e23cd89d4d5cd4388f8742130be1d6f182d
> > --
> > 2.39.5
>
>
--
Hugo Villeneuve
Powered by blists - more mailing lists