linux-kernel - Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250514164822.4b44dc5c@p-imbrenda>
Date: Wed, 14 May 2025 16:48:22 +0200
From: Claudio Imbrenda <imbrenda@...ux.ibm.com>
To: Christian Borntraeger <borntraeger@...ux.ibm.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
        Ignacio Moreno Gonzalez
 <Ignacio.MorenoGonzalez@...a.com>,
        kernel test robot <lkp@...el.com>, oe-kbuild-all@...ts.linux.dev,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Yang Shi
 <yang@...amperecomputing.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        David
 Hildenbrand <david@...hat.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily
 Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, kvm@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        pbonzini@...hat.com
Subject: Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error:
 expected identifier

On Wed, 14 May 2025 16:39:11 +0200
Christian Borntraeger <borntraeger@...ux.ibm.com> wrote:

> Am 14.05.25 um 16:27 schrieb Claudio Imbrenda:
> > On Wed, 14 May 2025 14:48:44 +0100
> > Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:
> >   
> >> +cc s390 people, kvm s390 people + lists. sorry for noise but get_maintainers.pl
> >> says there's a lot of you :)
> >>
> >> On Wed, May 14, 2025 at 03:28:47PM +0200, Ignacio Moreno Gonzalez wrote:  
> >>> Hi,
> >>>
> >>> Due to the line:
> >>>
> >>> include/linux/huge_mm.h:509 '#include <uapi/asm/mman.h>'  
> >>
> >> BTW, I didn't notice at the time, but shouldn't this be linux/mman.h? You
> >> shouldn't be importing this header this way generally (only other users are arch
> >> code).
> >>
> >> But at any rate, you will ultimately import the PROT_NONE declaration.
> >>  
> >>>
> >>> there is a name collision in arch/s390/kvm/gaccess.c, where 'PROT_NONE' is also defined as value for 'enum prot_type'.  
> >>
> >> That is crazy. Been there since 2022 also...!
> >>  
> >>>
> >>> A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.  
> > 
> > please write a patch to rename PROT_NONE in our enum to
> > PROT_TYPE_DUMMY, I can review it quickly.
> > 
> > if Paolo has no objections, I'm fine with having the patch go through
> > the mm tree  
> 
> Yes, lets do a quick fix and I can also do
> Acked-by: Christian Borntraeger <borntraeger@...ux.ibm.com>
> 
> for a s/PROT_NONE/PROT_TYPE_NONE/g
> patch.

I'd rather have PROT_TYPE_DUMMY, since it's a dummy value and not
something that indicates "no protection"