linux-kernel - Re: [PATCH] irqdomain: ppc: Switch to of_fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <zofmgipjaniwwwb43quo6eoct66cnq65g36dgnk2qbrs4p5kxr@ge5gilezyu6g>
Date: Wed, 14 May 2025 09:54:46 +0530
From: Mahesh J Salgaonkar <mahesh@...ux.ibm.com>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: maddy@...ux.ibm.com, tglx@...utronix.de, maz@...nel.org,
        linux-kernel@...r.kernel.org, Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Naveen N Rao <naveen@...nel.org>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] irqdomain: ppc: Switch to of_fwnode_handle()

On 2025-04-15 12:47:58 Tue, Jiri Slaby (SUSE) wrote:
> of_node_to_fwnode() is irqdomain's reimplementation of the "officially"
> defined of_fwnode_handle(). The former is in the process of being
> removed, so use the latter instead.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Madhavan Srinivasan <maddy@...ux.ibm.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
> Cc: Naveen N Rao <naveen@...nel.org>
> Cc: linuxppc-dev@...ts.ozlabs.org
> ---
> This is an indepent patch, please apply directly.
> 
> The patch was previously a part of a large series [1], but I would like
> maintainers to feed the independent parts through their trees.

Looks good to me.

Reviewed-by: Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>

Thanks,
-Mahesh.

> 
> [1] https://lore.kernel.org/all/20250319092951.37667-1-jirislaby@kernel.org/
> ---
>  arch/powerpc/platforms/powernv/pci-ioda.c | 2 +-
>  arch/powerpc/platforms/pseries/msi.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> index ae4b549b5ca0..d8ccf2c9b98a 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -1897,7 +1897,7 @@ static int __init pnv_msi_allocate_domains(struct pci_controller *hose, unsigned
>  		return -ENOMEM;
>  	}
>  
> -	hose->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(hose->dn),
> +	hose->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(hose->dn),
>  						     &pnv_msi_domain_info,
>  						     hose->dev_domain);
>  	if (!hose->msi_domain) {
> diff --git a/arch/powerpc/platforms/pseries/msi.c b/arch/powerpc/platforms/pseries/msi.c
> index f9d80111c322..5b191f70c088 100644
> --- a/arch/powerpc/platforms/pseries/msi.c
> +++ b/arch/powerpc/platforms/pseries/msi.c
> @@ -628,7 +628,7 @@ static int __pseries_msi_allocate_domains(struct pci_controller *phb,
>  		return -ENOMEM;
>  	}
>  
> -	phb->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(phb->dn),
> +	phb->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(phb->dn),
>  						    &pseries_msi_domain_info,
>  						    phb->dev_domain);
>  	if (!phb->msi_domain) {
> -- 
> 2.49.0
> 
> 

-- 
Mahesh J Salgaonkar