linux-kernel - Re: [PATCH v1] i2c: lpi2c: implement master_xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3C1EEBEB-E691-4EB7-A008-A1FE9CEE7238@dolcini.it>
Date: Wed, 14 May 2025 17:51:27 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Andi Shyti <andi.shyti@...nel.org>
CC: Dong Aisheng <aisheng.dong@....com>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Emanuele Ghidoli <emanuele.ghidoli@...adex.com>, linux-i2c@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org,
 Francesco Dolcini <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v1] i2c: lpi2c: implement master_xfer_atomic callback

Il 14 maggio 2025 17:14:32 CEST, Andi Shyti <andi.shyti@...nel.org> ha scritto:
>Hi Francesco and Emanuele,
>
>On Wed, Mar 19, 2025 at 03:51:14PM +0100, Francesco Dolcini wrote:
>> From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
>> 
>> Rework the read and write code paths in the driver to support operation
>> in atomic contexts. To achieve this, the driver must not rely on IRQs
>> or perform any scheduling, e.g., via a sleep or schedule routine. Even
>> jiffies do not advance in atomic contexts, so timeouts based on them
>> are substituted with delays.
>> 
>> Implement atomic, sleep-free, and IRQ-less operation. This increases
>> complexity but is necessary for atomic I2C transfers required by some
>> hardware configurations, e.g., to trigger reboots on an external PMIC chip.
>> 
>> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
>> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
>
>this patch is causing a build regression. I'm going to revert it,
>please check the test report that has been reported and you are
>cc'ed.
>
>Andi

I am looking at it, it's a warning with W=1, not a build error. I would not revert this patch, just wait for a follow up patch or comment that will address that warning.

Francesco