linux-kernel - Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250514181003.3b4caa3c@p-imbrenda>
Date: Wed, 14 May 2025 18:10:03 +0200
From: Claudio Imbrenda <imbrenda@...ux.ibm.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Ignacio Moreno
 Gonzalez <Ignacio.MorenoGonzalez@...a.com>,
        kernel test robot
 <lkp@...el.com>, oe-kbuild-all@...ts.linux.dev,
        Andrew Morton
 <akpm@...ux-foundation.org>,
        Linux Memory Management List
 <linux-mm@...ck.org>,
        Yang Shi <yang@...amperecomputing.com>,
        Janosch Frank
 <frankja@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Heiko
 Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander
 Gordeev <agordeev@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, kvm@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        pbonzini@...hat.com
Subject: Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error:
 expected identifier

On Wed, 14 May 2025 17:01:55 +0100
Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:

> On Wed, May 14, 2025 at 04:52:18PM +0200, Christian Borntraeger wrote:
> >
> >
> > Am 14.05.25 um 16:48 schrieb Claudio Imbrenda:
> >  
> > > > > > > A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.  
> > > > >
> > > > > please write a patch to rename PROT_NONE in our enum to
> > > > > PROT_TYPE_DUMMY, I can review it quickly.
> > > > >
> > > > > if Paolo has no objections, I'm fine with having the patch go through
> > > > > the mm tree  
> > > >
> > > > Yes, lets do a quick fix and I can also do
> > > > Acked-by: Christian Borntraeger <borntraeger@...ux.ibm.com>
> > > >
> > > > for a s/PROT_NONE/PROT_TYPE_NONE/g
> > > > patch.  
> > >
> > > I'd rather have PROT_TYPE_DUMMY, since it's a dummy value and not
> > > something that indicates "no protection"  
> >
> > makes sense.  
> 
> Thanks for the quick response guys, did you want us to write the patch?

yes please

please don't forget to also add the following tags:

Fixes: b3cefd6bf16e ("KVM: s390: Pass initialized arg even if unused")
Cc: stable@...r.kernel.org

> 
> We can put something together quickly if so and cc you on it.

yep

> 
> Ack on the comment above, of course!
> 
> Cheers, Lorenzo