linux-kernel - Re: [PATCH] media: i2c: imx415: Request the sensor clock without a name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ced4b6b2-69c4-4d84-ab8b-7360d2b80ebb@collabora.com>
Date: Wed, 14 May 2025 18:16:11 +0200
From: Michael Riesch <michael.riesch@...labora.com>
To: Matthias Fend <matthias.fend@...end.at>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c: imx415: Request the sensor clock without a
 name

Hi Matthias,

Thanks for giving this patch a spin.

FTR some context here:
https://lore.kernel.org/all/20241130141716.1007115-1-matthias.fend@emfend.at/

On 5/14/25 12:51, Matthias Fend wrote:
> Request the sensor clock without specifying a name so that the driver
> behaves as described in the imx415 bindings.
> 
> Signed-off-by: Matthias Fend <matthias.fend@...end.at>

Reviewed-by: Michael Riesch <michael.riesch@...labora.com>

Thanks and best regards,
Michael

> ---
>  drivers/media/i2c/imx415.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
> index 9f37779bd6111f434c198ad1cf70c14b80724042..278e743646ea15819d5a79577e786b47c259dbfa 100644
> --- a/drivers/media/i2c/imx415.c
> +++ b/drivers/media/i2c/imx415.c
> @@ -1251,7 +1251,7 @@ static int imx415_parse_hw_config(struct imx415 *sensor)
>  		return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset),
>  				     "failed to get reset GPIO\n");
>  
> -	sensor->clk = devm_clk_get(sensor->dev, "inck");
> +	sensor->clk = devm_clk_get(sensor->dev, NULL);
>  	if (IS_ERR(sensor->clk))
>  		return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk),
>  				     "failed to get clock\n");
> 
> ---
> base-commit: 9f35e33144ae5377d6a8de86dd3bd4d995c6ac65
> change-id: 20250514-imx415-c65889e55211
> 
> Best regards,