linux-kernel - Re: [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCQm0aHYnI6ciyPz@gondor.apana.org.au>
Date: Wed, 14 May 2025 13:14:57 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Klaus Kudielka <klaus.kudielka@...il.com>
Cc: Corentin Labbe <clabbe.montjoie@...il.com>, regressions@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	Boris Brezillon <bbrezillon@...nel.org>,
	EBALARD Arnaud <Arnaud.Ebalard@....gouv.fr>,
	Romain Perier <romain.perier@...il.com>
Subject: Re: [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor

On Wed, May 14, 2025 at 07:12:52AM +0200, Klaus Kudielka wrote:
>
> drivers/crypto/marvell/cesa/hash.c: In function ‘mv_cesa_ahash_complete’:
> drivers/crypto/marvell/cesa/hash.c:403:25: error: implicit declaration of function ‘HASH_FBREQ_ON_STACK’; did you mean ‘SHASH_DESC_ON_STACK’? [-Wimplicit-function-declaration]
>   403 |                         HASH_FBREQ_ON_STACK(fbreq, ahashreq);
>       |                         ^~~~~~~~~~~~~~~~~~~
>       |                         SHASH_DESC_ON_STACK
> drivers/crypto/marvell/cesa/hash.c:403:45: error: ‘fbreq’ undeclared (first use in this function)
>   403 |                         HASH_FBREQ_ON_STACK(fbreq, ahashreq);
>       |                                             ^~~~~
> drivers/crypto/marvell/cesa/hash.c:403:45: note: each undeclared identifier is reported only once for each function it appears in
> drivers/crypto/marvell/cesa/hash.c:405:25: error: implicit declaration of function ‘crypto_ahash_import_core’; did you mean ‘crypto_ahash_import’? [-Wimplicit-function-declaration]
>   405 |                         crypto_ahash_import_core(fbreq, &state);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~
>       |                         crypto_ahash_import
>   CC [M]  drivers/crypto/marvell/cesa/tdma.o
> drivers/crypto/marvell/cesa/hash.c:407:25: error: implicit declaration of function ‘crypto_ahash_export_core’; did you mean ‘crypto_ahash_export’? [-Wimplicit-function-declaration]
>   407 |                         crypto_ahash_export_core(fbreq, &state);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~
>       |                         crypto_ahash_export
> make[9]: *** [scripts/Makefile.build:203: drivers/crypto/marvell/cesa/hash.o] Error 1

Sorry, should've mentioned that this goes on top of the current
cryptodev tree:

https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/log/

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt