linux-kernel - Re: [PATCH] cdrom: Remove unnecessary NULL check before unregister_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aCURuvkmz-fw3Nnp@equinox>
Date: Wed, 14 May 2025 22:57:14 +0100
From: Phillip Potter <phil@...lpotter.co.uk>
To: Chen Ni <nichen@...as.ac.cn>
Cc: linux-kernel@...r.kernel.org, phil@...lpotter.co.uk
Subject: Re: [PATCH] cdrom: Remove unnecessary NULL check before
 unregister_sysctl_table()

On Wed, May 14, 2025 at 11:21:39AM +0800, Chen Ni wrote:
> unregister_sysctl_table() checks for NULL pointers internally.
> Remove unneeded NULL check here.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/cdrom/cdrom.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index b163e043c687..21a10552da61 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3677,8 +3677,7 @@ static void cdrom_sysctl_register(void)
>  
>  static void cdrom_sysctl_unregister(void)
>  {
> -	if (cdrom_sysctl_header)
> -		unregister_sysctl_table(cdrom_sysctl_header);
> +	unregister_sysctl_table(cdrom_sysctl_header);
>  }
>  
>  #else /* CONFIG_SYSCTL */
> -- 
> 2.25.1
> 

Thank you for the patch, looks good.

Reviewed-by: Phillip Potter <phil@...lpotter.co.uk>

I will send on for inclusion upstream.

Regards,
Phil