linux-kernel - Re: [PATCH v3 10/19] dt-bindings: media: i2c: max96712: deprecate enable-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250514221001.GA3125068-robh@kernel.org>
Date: Wed, 14 May 2025 17:10:01 -0500
From: Rob Herring <robh@...nel.org>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Cosmin Tanislav <cosmin.tanislav@...log.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Niklas Söderlund <niklas.soderlund@...natech.se>,
	Julien Massot <julien.massot@...labora.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Bjorn Andersson <andersson@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Vignesh Raghavendra <vigneshr@...com>,
	Nícolas F . R . A . Prado <nfraprado@...labora.com>,
	Taniya Das <quic_tdas@...cinc.com>, Liu Ying <victor.liu@....com>,
	Ross Burton <ross.burton@....com>,
	Elinor Montmasson <elinor.montmasson@...oirfairelinux.com>,
	Eric Biggers <ebiggers@...gle.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Zhi Mao <zhi.mao@...iatek.com>,
	Dongcheng Yan <dongcheng.yan@...el.com>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	Tommaso Merciai <tomm.merciai@...il.com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Ricardo Ribalda <ribalda@...omium.org>,
	Laurentiu Palcu <laurentiu.palcu@....nxp.com>,
	linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-staging@...ts.linux.dev, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 10/19] dt-bindings: media: i2c: max96712: deprecate
 enable-gpios

On Tue, May 13, 2025 at 12:28:19AM +0300, Cosmin Tanislav wrote:
> The MAX96712 actually has a GPIO named PWDNB, which will put the chip
> in reset state when held low. Esentially, it works as an enable GPIO,
> but the naming is different.
> 
> Deprecate the enable-gpios property, and add powerdown-gpios as the
> rest of the GMSL chips.
> 
> Change the example to use powerdown-gpios.

I don't know that this is worth changing because then we have to 
maintain both forever.

> Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>
> ---
>  .../devicetree/bindings/media/i2c/maxim,max96712.yaml  | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> index b345305acc4c..e38213209973 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> @@ -35,7 +35,13 @@ properties:
>      description: I2C device address
>      maxItems: 1
>  
> -  enable-gpios: true
> +  enable-gpios:
> +    maxItems: 1
> +    deprecated: true
> +
> +  powerdown-gpios:
> +    maxItems: 1
> +    description: Specifier for the GPIO connected to the PWDNB pin.
>  
>    i2c-alias-pool:
>      maxItems: 4
> @@ -128,7 +134,7 @@ examples:
>              gmsl0: gmsl-deserializer@49 {
>                      compatible = "maxim,max96712";
>                      reg = <0x49>;
> -                    enable-gpios = <&pca9654_a 0 GPIO_ACTIVE_HIGH>;
> +                    powerdown-gpios = <&pca9654_a 0 GPIO_ACTIVE_LOW>;
>  
>                      ports {
>                              #address-cells = <1>;
> -- 
> 2.49.0
>