linux-kernel - Re: [PATCH 1/5] objtool/rust: add one more `noreturn` Rust function for Rust 1.87.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4c946b2988d63a26aff2d03fe73fbfe1f52f31b.camel@nvidia.com>
Date: Wed, 14 May 2025 00:43:20 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "ojeda@...nel.org" <ojeda@...nel.org>, Joel Fernandes
	<joelagnelf@...dia.com>, John Hubbard <jhubbard@...dia.com>
CC: "dakr@...nel.org" <dakr@...nel.org>, "a.hindborg@...nel.org"
	<a.hindborg@...nel.org>, "boqun.feng@...il.com" <boqun.feng@...il.com>,
	"jpoimboe@...nel.org" <jpoimboe@...nel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>, "tmgross@...ch.edu" <tmgross@...ch.edu>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>, "alex.gaynor@...il.com"
	<alex.gaynor@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "benno.lossin@...ton.me"
	<benno.lossin@...ton.me>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "peterz@...radead.org" <peterz@...radead.org>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, Alexandre Courbot
	<acourbot@...dia.com>, "gary@...yguo.net" <gary@...yguo.net>, Alistair Popple
	<apopple@...dia.com>
Subject: Re: [PATCH 1/5] objtool/rust: add one more `noreturn` Rust function
 for Rust 1.87.0

On Tue, 2025-05-13 at 17:22 -0700, John Hubbard wrote:
> On 5/13/25 2:58 PM, Joel Fernandes wrote:
> > On Tue, May 13, 2025 at 02:07:57PM -0400, Joel Fernandes wrote:
> > > On Fri, May 02, 2025 at 04:02:33PM +0200, Miguel Ojeda wrote:
> > > > Starting with Rust 1.87.0 (expected 2025-05-15), `objtool` may report:
> ...
> > Btw, Danilo mentioned to me the latest Rust compiler (1.86?) does not give
> > this warning for that patch.
> 
> I'm sorry to burst this happy bubble, but I just upgraded to rustc 1.86 and did
> a clean build, and I *am* setting these warnings:

I see these warnings with .c code also:

  CHK     kernel/kheaders_data.tar.xz
drivers/media/pci/solo6x10/solo6x10-tw28.o: error: objtool: tw28_set_ctrl_val() falls through to
next function tw28_get_ctrl_val()
make[9]: *** [scripts/Makefile.build:203: drivers/media/pci/solo6x10/solo6x10-tw28.o] Error 1

I think it's an objtool bug and not a rustc bug.