linux-kernel - Re: [PATCH v1] i2c: designware: Don't warn about missing get_clk_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19dce124-1a73-4f92-b4ad-4c95c73364cb@linux.intel.com>
Date: Wed, 14 May 2025 09:58:01 +0300
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
 Raag Jadav <raag.jadav@...el.com>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] i2c: designware: Don't warn about missing
 get_clk_rate_khz

On 5/13/25 3:40 PM, Heikki Krogerus wrote:
> Converting the WARN_ON() to a dev_dbg() message in
> i2c_dw_clk_rate().
> 
> That removes the need to supply a dummy implementation for
> the callback (or alternatively a dummy clk device) when the
> fallback path is preferred where the existing values already
> in the clock registers are used - when a firmware has
> programmed the clock registers.
> 
> The fallback path was introduced in commit 4fec76e0985c
> ("i2c: designware: Fix wrong setting for {ss,fs,hs}_{h,l}cnt
> registers").
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
>   drivers/i2c/busses/i2c-designware-common.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>