linux-kernel - Re: [PATCH 1/1] PCI: Move reset and restore related code to reset-restore.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCRBFWHKa02Hu-ec@wunner.de>
Date: Wed, 14 May 2025 09:07:01 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/1] PCI: Move reset and restore related code to
 reset-restore.c

On Mon, May 12, 2025 at 03:08:57PM +0300, Ilpo Järvinen wrote:
> There are quite many reset and restore related functions in pci.c that
> barely depend on the other functions in pci.c. Create reset-restore.c
> for reset and restore related logic to keep those 1k lines in one place.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Hm, could I get a:

Suggested-by: Lukas Wunner <lukas@...ner.de>

... per:

https://lore.kernel.org/r/Z7hZZNT5NHYncZ3c@wunner.de/

>  drivers/pci/Makefile        |    4 +-
>  drivers/pci/pci.c           | 1015 +----------------------------------
>  drivers/pci/pci.h           |   10 +
>  drivers/pci/reset-restore.c | 1014 ++++++++++++++++++++++++++++++++++

I'd prefer reset.c for succinctness.

That said, this patch conflicts with Mani's slot reset patches
which a lot of people seem to be interested in:

https://lore.kernel.org/r/20250508-pcie-reset-slot-v4-0-7050093e2b50@linaro.org/

Maybe it's better to give Mani's series the advantage and defer
this patch here to the next cycle.


> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -69,15 +69,7 @@ struct pci_pme_device {
>   */
>  #define PCI_RESET_WAIT 1000 /* msec */

I'd move PCI_RESET_WAIT, pci_dev_wait() and
pci_bridge_wait_for_secondary_bus() to reset.c as well.

Then pci_dev_d3_sleep() is the only function which is no longer static.

Thanks,

Lukas