linux-kernel - Re: [PATCH] i2c: designware: Fix an error handling path in i2c_dw_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fe4e253-330d-4681-af89-834a045dd183@linux.intel.com>
Date: Wed, 14 May 2025 10:25:08 +0300
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
 Sanket Goswami <Sanket.Goswami@....com>, Wolfram Sang <wsa@...nel.org>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@....com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: designware: Fix an error handling path in
 i2c_dw_pci_probe()

On 5/13/25 8:56 PM, Christophe JAILLET wrote:
> If navi_amd_register_client() fails, the previous i2c_dw_probe() call
> should be undone by a corresponding i2c_del_adapter() call, as already done
> in the remove function.
> 
> Fixes: 17631e8ca2d3 ("i2c: designware: Add driver support for AMD NAVI GPU")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/i2c/busses/i2c-designware-pcidrv.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>