linux-kernel - Re: [PATCH 3/7] serial: 8250: Add PRUSS UART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025051408-discolor-backwash-5574@gregkh>
Date: Wed, 14 May 2025 09:36:45 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Judith Mendez <jm@...com>
Cc: Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Nishanth Menon <nm@...com>,
	Santosh Shilimkar <ssantosh@...nel.org>,
	Vignesh Raghavendra <vigneshr@...com>,
	Tero Kristo <kristo@...nel.org>, Bin Liu <b-liu@...com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Andrew Davis <afd@...com>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/7] serial: 8250: Add PRUSS UART driver

On Tue, May 13, 2025 at 04:59:30PM -0500, Judith Mendez wrote:
> From: Bin Liu <b-liu@...com>
> 
> This adds a new serial 8250 driver that supports the UART in PRUSS or
> PRU_ICSS*.
> 
> The UART sub-module is based on the industry standard TL16C550 UART
> controller, which has 16-bytes FIFO and supports 16x and 13x over
> samplings.

If it is based on an existing controller, why do we need a new driver
for this?  Please explain in detail why this code is needed at all, and
not just a new "quirk" for the existing driver?

thanks,

greg k-h