linux-kernel - Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4d5d337-6a08-4ca6-8fab-4b640e732c9f@nvidia.com>
Date: Wed, 14 May 2025 10:38:51 +0300
From: Gal Pressman <gal@...dia.com>
To: Tariq Toukan <ttoukan.linux@...il.com>, Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 Jiri Pirko <jiri@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
 Donald Hunter <donald.hunter@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 Jonathan Corbet <corbet@....net>, Saeed Mahameed <saeedm@...dia.com>,
 Leon Romanovsky <leon@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-rdma@...r.kernel.org, Moshe Shemesh <moshe@...dia.com>,
 Mark Bloch <mbloch@...dia.com>, Carolina Jubran <cjubran@...dia.com>,
 Cosmin Ratiu <cratiu@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
 Jason Gunthorpe <jgg@...pe.ca>, Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with
 traffic classes bandwidth management

On 12/05/2025 17:27, Tariq Toukan wrote:
>> I'm going to also give you a hint that my next complaint will be that
>> there are no selftests in this series, and it extends uAPI.
> 
> I have some questions, looking for answers in an official source.
> 
> Most importantly, it is unclear to me when a selftest is required. What
> is the guideline?
> 
> Please point me to any guidance for this selftest requirement. Is it
> generic, or networking subsystem specific?
> 
> Let's make sure these things are well-defined, so we plan the extra
> effort accordingly in future features, and improve predictability.

I have also asked this question in the past, but was ignored:
https://lore.kernel.org/netdev/68e2a8cc-2371-433b-86a3-ac9dea48fb43@nvidia.com/