linux-kernel - Re: [PATCH 3/3] media: allegro-dvt: Add DT-bindings for the Gen 3 IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c071c53e-4cbc-4daa-bb02-c8bce3eed538@kernel.org>
Date: Wed, 14 May 2025 10:01:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yassine Ouaissa <yassine.ouaissa@...egrodvt.com>
Cc: Michael Tretter <m.tretter@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Michal Simek <michal.simek@....com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Heiko Stuebner
 <heiko@...ech.de>, Aradhya Bhatia <a-bhatia1@...com>,
 Rafa?? Mi??ecki <rafal@...ecki.pl>, Junhao Xie <bigfoot@...ssfun.cn>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Kever Yang <kever.yang@...k-chips.com>, Hans Verkuil <hverkuil@...all.nl>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Andrzej Pietrasiewicz <andrzejtp2010@...il.com>,
 Joe Hattori <joe@...is.s.u-tokyo.ac.jp>,
 Gaosheng Cui <cuigaosheng1@...wei.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Uwe Kleine-K??nig <u.kleine-koenig@...libre.com>,
 Ricardo Ribalda <ribalda@...omium.org>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/3] media: allegro-dvt: Add DT-bindings for the Gen 3 IP

On 12/05/2025 13:17, Yassine Ouaissa wrote:
> On 12.05.2025 12:42, Krzysztof Kozlowski wrote:
>> On Mon, May 12, 2025 at 08:23:11AM GMT, Yassine Ouaissa wrote:
>>> issue fixed also, thanks.
>>>>> +  significant advancements over its predecessors. This new decoder features
>>>>> +  enhanced processing capabilities with improved throughput and reduced latency.
>>>>> +
>>>>> +  Communication between the host driver software and the MCU is implemented through
>>>>> +  a specialized mailbox interface mechanism. This mailbox system provides a
>>>>> +  structured channel for exchanging commands, parameters, and status information
>>>>> +  between the host CPU and the MCU controlling the codec engines.
>>>>> +
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    const: allegrodvt,al300-vdec
>>>>
>>>> Undocumented prefix.
>>>>
>>>> What is the actual device name? al300? Can you have al300-adec? or
>>>> al300-dec?
>>>>
>>>>
>>>
>>> the device name is al300, the vdec is for decoder driver.
>>
>> So drop vdec. Compatible should reflect device name.
>>
> 
> We cannot, the IP could have the encode and decode in the same time.
> the al300 is for the IP gen, and vdec/venc for the driver compatible.
> 
> I'll discuss with the team, about other naming.
Do not send next version - like you did now - before we finish
discussion. You just sent the same bypassing this entire discussion.

Explain what is the device name, what is the device so we can understand it.

I also expect all other comments to be implemented - including
clock-names and incorrect device node name.

Best regards,
Krzysztof