linux-kernel - [PATCH] mlxsw: spectrum: Reset lossiness configuration when changing MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250514082900.239-1-vulab@iscas.ac.cn>
Date: Wed, 14 May 2025 16:28:59 +0800
From: Wentao Liang <vulab@...as.ac.cn>
To: idosch@...dia.com,
	petrm@...dia.com,
	andrew+netdev@...n.ch,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com
Cc: netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Wentao Liang <vulab@...as.ac.cn>
Subject: [PATCH] mlxsw: spectrum: Reset lossiness configuration when changing MTU

The function mlxsw_sp_port_change_mtu() reset the buffer sizes but does
not reset the lossiness configuration of the buffers. This could lead to
inconsistent lossiness settings. A proper implementation can be found
in mlxsw_sp_port_headroom_ets_set().

Add lossiness reset by calling mlxsw_sp_hdroom_bufs_reset_lossiness().

Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 3f5e5d99251b..54aa1dca5076 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -797,6 +797,7 @@ static int mlxsw_sp_port_change_mtu(struct net_device *dev, int mtu)
 
 	hdroom = orig_hdroom;
 	hdroom.mtu = mtu;
+	mlxsw_sp_hdroom_bufs_reset_lossiness(&hdroom);
 	mlxsw_sp_hdroom_bufs_reset_sizes(mlxsw_sp_port, &hdroom);
 
 	err = mlxsw_sp_hdroom_configure(mlxsw_sp_port, &hdroom);
-- 
2.42.0.windows.2