linux-kernel - Re: [PATCH 2/2] ALSA: hda: cs35l56: Log tuning unique identifiers during firmware load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCRUgeFcG4iubmSV@finisterre.sirena.org.uk>
Date: Wed, 14 May 2025 10:29:53 +0200
From: Mark Brown <broonie@...nel.org>
To: Simon Trimmer <simont@...nsource.cirrus.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...nsource.cirrus.com, tiwai@...e.de
Subject: Re: [PATCH 2/2] ALSA: hda: cs35l56: Log tuning unique identifiers
 during firmware load

On Tue, May 13, 2025 at 01:39:24PM +0000, Simon Trimmer wrote:
> The cs35l56 smart amplifier has some informational firmware controls
> that are populated by a tuning bin file to unique values - logging these
> during firmware load identifies the specific configuration being used on
> that device instance.

Adding Takashi since this is an ALSA patch (and not deleting context for
him), Takashi is this OK to go via ASoC?

As documented in submitting-patches.rst please send patches to the 
maintainers for the code you would like to change.  The normal kernel
workflow is that people apply patches from their inboxes, if they aren't
copied they are likely to not see the patch at all and it is much more
difficult to apply patches.

> 
> Signed-off-by: Simon Trimmer <simont@...nsource.cirrus.com>
> ---
>  sound/pci/hda/cs35l56_hda.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
> index b6fecf119261..aed7d7284231 100644
> --- a/sound/pci/hda/cs35l56_hda.c
> +++ b/sound/pci/hda/cs35l56_hda.c
> @@ -676,6 +676,8 @@ static void cs35l56_hda_fw_load(struct cs35l56_hda *cs35l56)
>  	if (ret)
>  		cs_dsp_stop(&cs35l56->cs_dsp);
>  
> +	cs35l56_log_tuning(&cs35l56->base, &cs35l56->cs_dsp);
> +
>  err_powered_up:
>  	if (!cs35l56->base.fw_patched)
>  		cs_dsp_power_down(&cs35l56->cs_dsp);
> -- 
> 2.43.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)