linux-kernel - Re: [PATCH linux next] taskstats: fix struct taskstats breaks backward compatibility since version 15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250514095715517YAAvcCEiCPevDbByvfkG8@zte.com.cn>
Date: Wed, 14 May 2025 09:57:15 +0800 (CST)
From: <yang.yang29@....com.cn>
To: <jiang.kun2@....com.cn>, <wang.yaxin@....com.cn>
Cc: <bbonev@...uan.org>, <linux-kernel@...r.kernel.org>,
        <bsingharora@...il.com>, <jiang.kun2@....com.cn>,
        <xu.xin16@....com.cn>, <akpm@...ux-foundation.org>
Subject: Re: [PATCH linux next] taskstats: fix struct taskstats breaks backward
 compatibility since version 15

> Solution> =========> move delay max and delay min to the end of taskstat, and bump> the version to 16 after the change
Please notice Documentation/accounting/taskstats.rst, it said:
Adding more fields to the end of the existing struct taskstats.

> + __u64 wpcopy_delay_max;> + __u64 wpcopy_delay_min;
There seems to have a whitespace problems, else LGTM.
Reviewed-by: Yang Yang <yang.yang29@....com.cn>

Another thing to make it better (maybe next patch): struct taskstats
had comments to explain xxx_count and xxx_delay_total, we should
also explain xxx_delay_min/max.
<div class="zcontentRow"><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;">&gt; <span style="font-family: Arial, &quot;Microsoft Yahei&quot;, &quot;Lucida Grande&quot;, Verdana, Lucida, Helvetica, sans-serif; background-color: rgb(255, 255, 255);">Solution</span><br style="box-sizing: border-box; outline: 0px; font-family: Arial, &quot;Microsoft Yahei&quot;, &quot;Lucida Grande&quot;, Verdana, Lucida, Helvetica, sans-serif; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: Arial, &quot;Microsoft Yahei&quot;, &quot;Lucida Grande&quot;, Verdana, Lucida, Helvetica, sans-serif; background-color: rgb(255, 255, 255);">&gt; =========</span><br style="box-sizing: border-box; outline: 0px; font-family: Arial, &quot;Microsoft Yahei&quot;, &quot;Lucida Grande&quot;, Verdana, Lucida, Helvetica, sans-serif; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: Arial, &quot;Microsoft Yahei&quot;, &quot;Lucida Grande&quot;, Verdana, Lucida, Helvetica, sans-serif; background-color: rgb(255, 255, 255);">&gt; move delay max and delay min to the end of taskstat, and bump</span><br style="box-sizing: border-box; outline: 0px; font-family: Arial, &quot;Microsoft Yahei&quot;, &quot;Lucida Grande&quot;, Verdana, Lucida, Helvetica, sans-serif; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: Arial, &quot;Microsoft Yahei&quot;, &quot;Lucida Grande&quot;, Verdana, Lucida, Helvetica, sans-serif; background-color: rgb(255, 255, 255);">&gt; the version to 16 after the change</span></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;">Please notice&nbsp;Documentation/accounting/taskstats.rst, it said:</p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;">Adding more fields to the end of the existing struct taskstats.</p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p>&gt; + __u64 wpcopy_delay_max;<br style="box-sizing: border-box; outline: 0px; font-family: Arial, &quot;Microsoft Yahei&quot;, &quot;Lucida Grande&quot;, Verdana, Lucida, Helvetica, sans-serif; white-space: normal; background-color: rgb(255, 255, 255);">&gt; + __u64 wpcopy_delay_min;</p><p>There seems to have a whitespace problems, else LGTM.</p><p>Reviewed-by:&nbsp;Yang Yang &lt;yang.yang29@....com.cn&gt;</p><p><br></p><p>Another thing to make it better (maybe next patch): struct taskstats</p><p>had comments to explain xxx_count and xxx_delay_total, we should</p><p>also explain xxx_delay_min/max.</p></div>